ProductCart E-Commerce Solutions Homepage
Forum Home Forum Home > ProductCart > Using ProductCart
  New Posts New Posts RSS Feed - Changes to PrdsalesReport.asp
  FAQ FAQ  Forum Search   Events   Register Register  Login Login

Changes to PrdsalesReport.asp

 Post Reply Post Reply
Author
Message
Dean View Drop Down
Newbie
Newbie
Avatar

Joined: 28-October-2005
Location: United States
Status: Offline
Points: 0
Post Options Post Options   Thanks (0) Thanks(0)   Quote Dean Quote  Post ReplyReply Direct Link To This Post Topic: Changes to PrdsalesReport.asp
    Posted: 29-June-2008 at 1:54pm
I've just upgraded from 2.76 and while the process was relatively painless there are some changes I have made to the code of PrdsalesReport.asp that I'd like to bring forward.  Comparing the code between 3.11 vs 2.76 shows a large number of changes.  I've run some tests using the old code and everything seems to work the way I'd like, but my tests haven't been exhaustive. 

Is there any harm or will other reports quit working if I just replace the 3.11 code with the modified 2.76 code?
Back to Top
Hamish View Drop Down
Admin Group
Admin Group


Joined: 12-October-2006
Location: United Kingdom
Status: Offline
Points: 56
Post Options Post Options   Thanks (0) Thanks(0)   Quote Hamish Quote  Post ReplyReply Direct Link To This Post Posted: 29-June-2008 at 3:35pm
Hi Dean,
    As this is reporting I very much doubt there is any code in there which does DB updates - in which case it would be "safe".  However, if you do decide to do this  then I would advise only doing it as a short term stop-gap.  I personally would advise against it though. The danger in this approach is that you will end up, in a future release with code that will not work and a lot more pain trying to work out what changes you made and how to bring them across to the version that is even more different. I've had to go in and tidy up after others had done this in the past & it's not fun!

There are lots of products out there which help you to compare files to ease the migration of your changes. Personally I use GVIM, but that has a  pretty steep learning curve. I've heard good things about winmerge though. http://winmerge.org/
Of couse, documenting your changes always helps as well. Not sure if you've done this already (hopefully so), but if not then this is a great opportunity to do so.

Regards,
     Hamish
    

Back to Top
Hamish View Drop Down
Admin Group
Admin Group


Joined: 12-October-2006
Location: United Kingdom
Status: Offline
Points: 56
Post Options Post Options   Thanks (0) Thanks(0)   Quote Hamish Quote  Post ReplyReply Direct Link To This Post Posted: 29-June-2008 at 4:08pm
Hi, I just did a quick diff of the two versions. There are some extra chunks of code & some lines have minor changes such as formatting, but it shouldn't be difficult integrating any changes you made unles they were major.
I often achieve this with a "3 way diff" (well techically a two way diff & the new version of the file also open to take the migrated changes)- where I compare my changed version with the original version (V2.76) - which makes it easy to see what I changed and where & then copy the change lines over to the new version (V3.11) - not forgetting to back up the V3.11 version before I start of course :-)
Back to Top
Dean View Drop Down
Newbie
Newbie
Avatar

Joined: 28-October-2005
Location: United States
Status: Offline
Points: 0
Post Options Post Options   Thanks (0) Thanks(0)   Quote Dean Quote  Post ReplyReply Direct Link To This Post Posted: 30-June-2008 at 3:29pm
Hamish - You sir are awesome!  I downloaded Winmerge and it totally saved the day.  When I make changes I document every line, so moving what I did to the new version was easy using Winmerge.

Thanks again.
Back to Top
Hamish View Drop Down
Admin Group
Admin Group


Joined: 12-October-2006
Location: United Kingdom
Status: Offline
Points: 56
Post Options Post Options   Thanks (0) Thanks(0)   Quote Hamish Quote  Post ReplyReply Direct Link To This Post Posted: 30-June-2008 at 3:33pm
Hi Dean,
  No problem - Thank the folks at Winmerge - they did the hard bit :-)

Back to Top
 Post Reply Post Reply
  Share Topic   

Forum Jump Forum Permissions View Drop Down

Forum Software by Web Wiz Forums® version 12.04
Copyright ©2001-2021 Web Wiz Ltd.

This page was generated in 0.047 seconds.